Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix constraint distribution state in simulation settings #9932

Merged
merged 1 commit into from
Dec 12, 2024
Merged

front: fix constraint distribution state in simulation settings #9932

merged 1 commit into from
Dec 12, 2024

Conversation

RomainValls
Copy link
Contributor

close #9811

@RomainValls RomainValls self-assigned this Dec 3, 2024
@RomainValls RomainValls requested a review from a team as a code owner December 3, 2024 15:11
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 3, 2024
@RomainValls RomainValls requested review from Math-R and Yohh December 3, 2024 15:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (f2d4da3) to head (278a86b).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9932      +/-   ##
==========================================
- Coverage   80.04%   80.02%   -0.02%     
==========================================
  Files        1049     1049              
  Lines      105292   105293       +1     
  Branches      757      758       +1     
==========================================
- Hits        84277    84259      -18     
- Misses      20974    20993      +19     
  Partials       41       41
Flag Coverage Δ
editoast 74.20% <ø> (-0.07%) ⬇️
front 89.23% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clarani
clarani requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum it would be better to fix this directly in the action selectTrainToEdit ;) you can get the constraint_distribution of the trainSchedule there and directly set the state

@RomainValls RomainValls requested a review from clarani December 5, 2024 10:38
@RomainValls RomainValls force-pushed the rvs/front-fix-constraint-distribution-state branch 2 times, most recently from 9b258e8 to 3de2fda Compare December 6, 2024 09:37
@RomainValls RomainValls requested a review from clarani December 6, 2024 09:37
clarani
clarani approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Math-R
Math-R approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@RomainValls RomainValls force-pushed the rvs/front-fix-constraint-distribution-state branch 3 times, most recently from c4188e1 to be6e812 Compare December 10, 2024 14:52
@RomainValls RomainValls added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@RomainValls RomainValls added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@RomainValls RomainValls force-pushed the rvs/front-fix-constraint-distribution-state branch from be6e812 to 278a86b Compare December 12, 2024 09:17
@RomainValls RomainValls added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@RomainValls RomainValls added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@RomainValls RomainValls added this pull request to the merge queue Dec 12, 2024
Merged via the queue into dev with commit 9e75ce2 Dec 12, 2024
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-constraint-distribution-state branch December 12, 2024 11:51
@Synar Synar mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@Math-R Math-R Math-R approved these changes

@clarani clarani clarani approved these changes

Assignees

@RomainValls RomainValls

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regularity margin parameter is set for all trains when you change it
5 participants
@RomainValls @codecov-commenter @Yohh @Math-R @clarani